martinvonz added inline comments. INLINE COMMENTS
> bundle2.py:368 > + def __exit__(self, type, exc, tb): > if not self.iterator: > return Doesn't look like this can actually happen (if used properly in a with-statement) > bundle2.py:402 > + if seekerror: > + raise exc > + Looks like a small change in behavior here: the debug message below used to always be printed (before this patch and also before this series). Just pointing it out in case you didn't notice. I'll let you decide if it's worth restoring the message by putting it back in a finally-block. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D705 To: durham, #hg-reviewers, indygreg Cc: martinvonz, indygreg, mercurial-devel _______________________________________________ Mercurial-devel mailing list Mercurial-devel@mercurial-scm.org https://www.mercurial-scm.org/mailman/listinfo/mercurial-devel
