indygreg accepted this revision.
indygreg added inline comments.
This revision is now accepted and ready to land.
INLINE COMMENTS
> dirstate.py:1299
> class dirstatemap(object):
> - def __init__(self):
> + def __init__(self, opener, ui, root):
> + self._opener = opener
Nit: I think `ui` should be the first argument.
> dirstate.py:1373-1374
> + fp.close()
> + raise error.Abort(_('working directory state may be '
> + 'changed parallelly'))
> + self._pendingmode = mode
This (pre-existing) error message is pretty bad because typical end users won't
have a clue what it means or what to do if they see it.
REPOSITORY
rHG Mercurial
REVISION DETAIL
https://phab.mercurial-scm.org/D757
To: durham, #hg-reviewers, indygreg
Cc: indygreg, mercurial-devel
_______________________________________________
Mercurial-devel mailing list
Mercurial-devel@mercurial-scm.org
https://www.mercurial-scm.org/mailman/listinfo/mercurial-devel
