durin42 added a comment.
In https://phab.mercurial-scm.org/D1063#17791, @martinvonz wrote: > In https://phab.mercurial-scm.org/D1063#17789, @durin42 wrote: > > > I'm a fan. Will give it to Monday for any objections. > > > I'm against. I'd like to see that the feature is indeed powerful enough for handling the intended use cases before we turn it on. Once it's on, we can't go back. The intended use case I'm aware of is to mimic "hg restack", IIUC. Maybe you have already switched over to using this (multi-dest rebase) internally at FB and seen that it does work well? > > What's the advantage of turning it on? It seems like very few users would use it directly anyway. Won't you provide aliases instead and those aliases could then also enable the feature? In https://phab.mercurial-scm.org/D1063#17931, @quark wrote: > In https://phab.mercurial-scm.org/D1063#17791, @martinvonz wrote: > > > In https://phab.mercurial-scm.org/D1063#17789, @durin42 wrote: > > > > > I'm a fan. Will give it to Monday for any objections. > > > > > > I'm against. I'd like to see that the feature is indeed powerful enough for handling the intended use cases before we turn it on. Once it's on, we can't go back. The intended use case I'm aware of is to mimic "hg restack", IIUC. Maybe you have already switched over to using this (multi-dest rebase) internally at FB and seen that it does work well? > > > Define "powerful enough for handling the intended use cases" precisely? I think what @martinvonz is getting at here is that we'd like to have some confidence that this is the right interface, by satisfying ourselves that this has been at least somewhat fieldtested at FB, if not anywhere else. Have you been doing so, and has it helped `hg restack` or whatever be simpler to implement? > > >> What's the advantage of turning it on? It seems like very few users would use it directly anyway. Won't you provide aliases instead and those aliases could then also enable the feature? > > Aliases cannot use `--config`. Yes, this is a known issue, and largely orthogonal to the concern here IMO (could still be done as a shell alias.) REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D1063 To: quark, #hg-reviewers, durin42 Cc: martinvonz, durin42, mercurial-devel _______________________________________________ Mercurial-devel mailing list Mercurial-devel@mercurial-scm.org https://www.mercurial-scm.org/mailman/listinfo/mercurial-devel
