phillco added inline comments.

INLINE COMMENTS

> ryanmce wrote in test-arbitraryfilectx.t:4-5
>   --- /data/users/rmcelroy/mercurial/hg/tests/test-check-module-imports.t
>   +++ /data/users/rmcelroy/mercurial/hg/tests/test-check-module-imports.t.err
>   @@ -42,3 +42,6 @@
>      > -X tests/test-lock.py \
>      > -X tests/test-verify-repo-operations.py \
>      > | sed 's-\\-/-g' | $PYTHON "$import_checker" -
>   +  tests/test-arbitraryfilectx.t:4: imports from mercurial not lexically 
> sorted: commands < context
>   +  tests/test-arbitraryfilectx.t:5: stdlib import "filecmp" follows local 
> import: mercurial
>   +  [1]
> 
> I can fix this in flight. Are you running all the `test-check-*.t` tests 
> locally?

hm, something might be up with my setup, definitely got a green on everything. 
I'll look into it.

> ryanmce wrote in test-arbitraryfilectx.t:8-13
> What a terrible, evil extension!

You misspelled "glorious"!

REPOSITORY
  rHG Mercurial

REVISION DETAIL
  https://phab.mercurial-scm.org/D1165

To: phillco, #hg-reviewers, ryanmce
Cc: ryanmce, mercurial-devel
_______________________________________________
Mercurial-devel mailing list
Mercurial-devel@mercurial-scm.org
https://www.mercurial-scm.org/mailman/listinfo/mercurial-devel

Reply via email to