durin42 requested changes to this revision. durin42 added inline comments. INLINE COMMENTS
> krbullock wrote in merge.py:1739-1743 > It's been our style basically forever to use parens instead of backslashes. > I'm honestly shocked we don't have a check-code rule for this. Yes, definitely use parens and not \. > quark wrote in test-fsmonitor-warning.t:9 > There was no fsmonitor related tests. So I think this is fine. You could easily fold this into any number of existing tests - really all you need is a repo with N files, and the ability to clone twice in a `#if` block. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D894 To: indygreg, #hg-reviewers, mbthomas, krbullock, durin42 Cc: durin42, quark, krbullock, mbthomas, mercurial-devel _______________________________________________ Mercurial-devel mailing list Mercurial-devel@mercurial-scm.org https://www.mercurial-scm.org/mailman/listinfo/mercurial-devel
