yuja added inline comments.

INLINE COMMENTS

> rebase.py:597
>      ('a', 'abort', False, _('abort an interrupted rebase'))] +
>       templateopts,
>      _('[-s REV | -b REV] [-d REV] [OPTION]'))

I'm surprised that the rebase command does have -T and --style
options from the very start. No idea how they would work, though.

> rebase.py:1549
> +    if fm:
> +        nodechanges = {hex(oldn): [hex(n) for n in newn]
> +                       for oldn, newn in replacements.iteritems()}

fm.hexfunc() could be used.

> rebase.py:1551
> +                       for oldn, newn in replacements.iteritems()}
> +        fm.data(nodechanges=nodechanges)
>  

Needs to wrap dict/list by fm.formatdict()/fm.formatlist()
to support -T "{user template}".

Can you send a follow up after 4.4 release?

REPOSITORY
  rHG Mercurial

REVISION DETAIL
  https://phab.mercurial-scm.org/D1173

To: pulkit, #hg-reviewers, dlax, durin42
Cc: yuja, durin42, dlax, mercurial-devel
_______________________________________________
Mercurial-devel mailing list
Mercurial-devel@mercurial-scm.org
https://www.mercurial-scm.org/mailman/listinfo/mercurial-devel

Reply via email to