yuja requested changes to this revision.
yuja added a comment.
This revision now requires changes to proceed.
Can you add a test that should be fixed by this patch?
Perhaps that will show we'll probably want to set the name of dict item pair
other than the default 'key'/'value'.
INLINE COMMENTS
> rebase.py:1550
> + fd = fm.formatdict
> + nodechanges = fd({hf(oldn): fl([hf(n) for n in newn], 'succs')
> + for oldn, newn in replacements.iteritems()})
The name argument is for each item, not for the list. Perhaps,
it should be name='node' (or name ='succ').
REPOSITORY
rHG Mercurial
REVISION DETAIL
https://phab.mercurial-scm.org/D1293
To: pulkit, #hg-reviewers, yuja
Cc: yuja, mercurial-devel
_______________________________________________
Mercurial-devel mailing list
Mercurial-devel@mercurial-scm.org
https://www.mercurial-scm.org/mailman/listinfo/mercurial-devel
