dlax added a comment.
LGTM modulo a few nits. Nice cleanup.
INLINE COMMENTS
> hgk.py:79
> ('S', 'search', "", _('search'))],
> - ('[OPTION]... NODE1 NODE2 [FILE]...'),
> + '[OPTION]... NODE1 NODE2 [FILE]...',
> inferrepo=True)
Why this extra indentation?
> hgk.py:337
> ('n', 'max-count', 0, _('max-count'))],
> - ('[OPTION]... REV...'))
> + '[OPTION]... REV...')
> def revlist(ui, repo, *revs, **opts):
Spurious indentation changes here as well.
> bookmarks.py:319
> parents = [p.node() for p in repo[None].parents()]
> - return (mark in marks and marks[mark] in parents)
> + return mark in marks and marks[mark] in parents
>
I'd keep this one as it makes it clearer that we return a generator. Arguably,
that's nitpicking.
REPOSITORY
rHG Mercurial
REVISION DETAIL
https://phab.mercurial-scm.org/D1371
To: indygreg, #hg-reviewers
Cc: dlax, mercurial-devel
_______________________________________________
Mercurial-devel mailing list
Mercurial-devel@mercurial-scm.org
https://www.mercurial-scm.org/mailman/listinfo/mercurial-devel
