phillco added inline comments.

INLINE COMMENTS

> dlax wrote in rebase.py:995
> Isn't it meant to be used in the function body? I see a `wctx = repo[None]` 
> below, perhaps it should be dropped.
> 
> But this wouldn't work with a `None` default value as mentioned in the next 
> patch.

Yes, it's used in the next patch. But you're right that it's the only callsite, 
so I've made it non-optional.

REPOSITORY
  rHG Mercurial

REVISION DETAIL
  https://phab.mercurial-scm.org/D1245

To: phillco, #hg-reviewers, durin42, dlax
Cc: dlax, mercurial-devel
_______________________________________________
Mercurial-devel mailing list
Mercurial-devel@mercurial-scm.org
https://www.mercurial-scm.org/mailman/listinfo/mercurial-devel

Reply via email to