indygreg created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers.
REVISION SUMMARY AFAICT sshserver.lock is unused. The last caller of it disappeared in https://phab.mercurial-scm.org/rHG9f6e0e7ef82884e3ec66455dac7312820c2b35ce ~18 months ago as part of removing code to support ancient wire protocol commands. Let's remove some dead code. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D1986 AFFECTED FILES mercurial/wireprotoserver.py CHANGE DETAILS diff --git a/mercurial/wireprotoserver.py b/mercurial/wireprotoserver.py --- a/mercurial/wireprotoserver.py +++ b/mercurial/wireprotoserver.py @@ -250,7 +250,6 @@ def __init__(self, ui, repo): self.ui = ui self.repo = repo - self.lock = None self.fin = ui.fin self.fout = ui.fout self.name = 'ssh' @@ -321,12 +320,8 @@ self.fout.flush() def serve_forever(self): - try: - while self.serve_one(): - pass - finally: - if self.lock is not None: - self.lock.release() + while self.serve_one(): + pass sys.exit(0) handlers = { To: indygreg, #hg-reviewers Cc: mercurial-devel _______________________________________________ Mercurial-devel mailing list Mercurial-devel@mercurial-scm.org https://www.mercurial-scm.org/mailman/listinfo/mercurial-devel
