yuja requested changes to this revision.
yuja added a comment.
This revision now requires changes to proceed.


  These functions look quite similar. Perhaps we can extract a helper function
  `f(repo, subset, x, rtypes)`.

INLINE COMMENTS

> remotenames.py:35
>      registrar,
> +    revset,
> +    smartset,

Minor nit: use `revsetlang` instead.

> remotenames.py:263
> +
> +@revsetpredicate('remotenames')
> +def remotenamesrevset(repo, subset, x):

Perhaps this should be:

  @revsetpredicate('remotenames()')
  def remotenamesrevset...
      """All changesets ...

> remotenames.py:268
> +    """
> +    revset.getargs(x, 0, 0, "remotenames takes no arguments")
> +    remoterevs = set()

Nit: `_("remotenames takes no arguments")`.

> remotenames.py:277
> +
> +    results = (cl.rev(n) for n in remoterevs if n in repo)
> +    return subset & smartset.baseset(sorted(results))

`cl.hasnode(n)` instead of `n in repo`, which creates a changectx
object?

REPOSITORY
  rHG Mercurial

REVISION DETAIL
  https://phab.mercurial-scm.org/D2002

To: pulkit, #hg-reviewers, yuja
Cc: yuja, mercurial-devel
_______________________________________________
Mercurial-devel mailing list
Mercurial-devel@mercurial-scm.org
https://www.mercurial-scm.org/mailman/listinfo/mercurial-devel

Reply via email to