martinvonz requested changes to this revision.
martinvonz added inline comments.
This revision now requires changes to proceed.

INLINE COMMENTS

> narrowrevlog.py:16-20
>  ELLIPSIS_NODE_FLAG = 1 << 14
>  revlog.REVIDX_KNOWN_FLAGS |= ELLIPSIS_NODE_FLAG
> -if (util.safehasattr(revlog, 'REVIDX_FLAGS_ORDER') and
> -    ELLIPSIS_NODE_FLAG not in revlog.REVIDX_FLAGS_ORDER):
> -        revlog.REVIDX_FLAGS_ORDER.append(ELLIPSIS_NODE_FLAG)

looks like you can instead drop all of this since we have now (since 
https://phab.mercurial-scm.org/rHG08b34c3a6f74800b5b357f371568177827963e2b) 
defined the flag in revlog.py  (and just use revlog.REVIDX_ELLIPSIS instead 
below)

REPOSITORY
  rHG Mercurial

REVISION DETAIL
  https://phab.mercurial-scm.org/D1977

To: durin42, #hg-reviewers, martinvonz
Cc: martinvonz, mercurial-devel
_______________________________________________
Mercurial-devel mailing list
Mercurial-devel@mercurial-scm.org
https://www.mercurial-scm.org/mailman/listinfo/mercurial-devel

Reply via email to