On Mon, 12 Feb 2018 14:55:57 +0100, Gábor Stefanik wrote:
> # HG changeset patch
> # User Gábor Stefanik <gabor.stefa...@nng.com>
> # Date 1518443649 -3600
> #      Mon Feb 12 14:54:09 2018 +0100
> # Node ID fe38aeeb1586464769caa6e9bb819078028fc858
> # Parent  1085c904d8c04d51c6897027fe9c7bae0964b64b
> [b] ignore close() on non-open clients (issue5751)
  ^^^
  what's [b]?

Thanks, this looks good, except the patch is malformed because of a corporate
mail server?

> diff -r 1085c904d8c0 -r fe38aeeb1586 hglib/client.py
> --- a/hglib/client.py   Thu Feb 01 15:10:02 2018 -0500
> +++ b/hglib/client.py   Mon Feb 12 14:54:09 2018 +0100
> @@ -294,6 +294,8 @@
>          return self._close()[0]
> 
>      def _close(self):
> +        if not self.server:
> +            return 0, ''

I slight prefer moving this to close() so _close() stays as a low-level
helper, but that doesn't matter in practice.

>          _sout, serr = self.server.communicate()
>          ret = self.server.returncode
>          self.server = None
_______________________________________________
Mercurial-devel mailing list
Mercurial-devel@mercurial-scm.org
https://www.mercurial-scm.org/mailman/listinfo/mercurial-devel

Reply via email to