indygreg accepted this revision.
indygreg added a comment.

  I'm happy with this as a first revision.
  While I'm accepting as hg-reviewers, I think C code should have an extra set 
of eyes. So I'll defer to @yuja to queue it.
  For the record, I'm no fan of not having braces for all bodies of 
conditionals. Can't wait to globally reformat our code to fix that.


> yuja wrote in bdiff.c:185
> Nit: `static bool sliceintolist(`

This doesn't need to be static. I'd declare it as `inline bool sliceintolist(`.

  rHG Mercurial


To: durin42, #hg-reviewers, indygreg, yuja
Cc: indygreg, yuja, mercurial-devel
Mercurial-devel mailing list

Reply via email to