indygreg accepted this revision.
indygreg added inline comments.
This revision is now accepted and ready to land.

INLINE COMMENTS

> pathencode.c:129-130
>                               charcopy(dest, &destlen, destsize, src[i++]);
> -                     }
> -                     else state = DDEFAULT;
> +                     } else
> +                             state = DDEFAULT;
>                       break;

I actually prefer the old style. But the good thing about using clang-format is 
we can bikeshed on the style later and mass rewrite things after that debate 
has concluded with minimal effort. So getting things to clang format is the 
important goal here, not bikeshedding about the style it is using today.

> pathencode.c:283-284
>                       switch (src[i]) {
> -                     case '1': case '2': case '3': case '4': case '5':
> -                     case '6': case '7': case '8': case '9':
>                               state = COMLPTn;

/me screams

REPOSITORY
  rHG Mercurial

REVISION DETAIL
  https://phab.mercurial-scm.org/D2178

To: durin42, #hg-reviewers, indygreg
Cc: indygreg, mercurial-devel
_______________________________________________
Mercurial-devel mailing list
Mercurial-devel@mercurial-scm.org
https://www.mercurial-scm.org/mailman/listinfo/mercurial-devel

Reply via email to