durin42 created this revision.
Herald added a subscriber: mercurial-devel.
Herald added a reviewer: hg-reviewers.
We should clean this up considerably when remotefilelog lands, which
we expect to try and accomplish in the near-ish future.
diff --git a/hgext/narrow/narrowrevlog.py b/hgext/narrow/narrowrevlog.py
@@ -156,6 +156,10 @@
# rename-checking logic when on remotefilelog. This
# might be incorrect on other non-revlog-based storage
# engines, but for now this seems to be fine.
+ # TODO: when remotefilelog is in core, improve this to
+ # explicitly look for remotefilelog instead of cheating
+ # with a hasattr check.
if util.safehasattr(self, 'node'):
node = self.node(rev)
# Because renamed() is overridden above to
To: durin42, #hg-reviewers
Mercurial-devel mailing list