indygreg requested changes to this revision.
indygreg added a comment.
This revision now requires changes to proceed.


  I'm not super thrilled about this. Presumably we'll have this class of 
failure throughout the code base. What do you think about having `node.bin()` 
catch `binascii.Error` and re-raise as `TypeError`?

REPOSITORY
  rHG Mercurial

REVISION DETAIL
  https://phab.mercurial-scm.org/D2244

To: durin42, #hg-reviewers, indygreg
Cc: indygreg, mercurial-devel
_______________________________________________
Mercurial-devel mailing list
Mercurial-devel@mercurial-scm.org
https://www.mercurial-scm.org/mailman/listinfo/mercurial-devel

Reply via email to