indygreg accepted this revision.
indygreg added a comment.
This revision is now accepted and ready to land.
In https://phab.mercurial-scm.org/D2244#37169, @durin42 wrote:
> I could go either way. A casual grep for "except TypeError" suggests we're
looking at 4 or 5 locations *total*, so my bias is to do it at the callsites
and avoid the annoyingly-large overhead of a wrapper function for something
that's so fundamental.
If it's only 4 or 5 call sites, then I'm not worried. I assumed it would be
more widespread than that.
To: durin42, #hg-reviewers, indygreg
Cc: indygreg, mercurial-devel
Mercurial-devel mailing list