indygreg added inline comments.
> + ui = repo.ui
> + username = ui.shortuser(ui.environ.get('REMOTE_USER') or ui.username())
> + user_includes = ui.configlist(
`REMOTE_USER` is an HTTP-ism and I think it is a layering violation to look for
`REMOTE_USER` in code that is supposed to be protocol agnostic.
What I'm trying to say is I think we'll need to tweak this ACL code further
when it is moved to core.
To: idlsoft, #hg-reviewers, durin42
Cc: indygreg, mercurial-devel
Mercurial-devel mailing list