martinvonz added inline comments.
> +class remotenames(dict):
> + """
Why does this extend dict? Do we expect callers to update bookmarks by doing
something like the following? If not, and the extending of dict is just for the
convenience of writing the loop in loadnames() below, we should do it
differently and not expose the dict-ness to users. For example, this class
could have a dict instead of being a dict.
remotenames = ...
remotenames['my-bookmark'] = node
To: pulkit, #hg-reviewers, durin42
Cc: martinvonz, durin42, mercurial-devel
Mercurial-devel mailing list