martinvonz (Martin von Zweigbergk) <phabrica...@mercurial-scm.org> writes:
> martinvonz added inline comments. > > INLINE COMMENTS > >> remotenames.py:23 >> + >> +class remotenames(dict): >> + """ > > Why does this extend dict? Do we expect callers to update bookmarks by doing > something like the following? If not, and the extending of dict is just for > the convenience of writing the loop in loadnames() below, we should do it > differently and not expose the dict-ness to users. For example, this class > could have a dict instead of being a dict. > > remotenames = ... > remotenames['my-bookmark'] = node When I wrote this, updating the bookmark (IIRC) was done through a dict-like interface. Or perhaps I wanted it to be that way so that's how I wrote it here.
signature.asc
Description: PGP signature
_______________________________________________ Mercurial-devel mailing list Mercurial-devel@mercurial-scm.org https://www.mercurial-scm.org/mailman/listinfo/mercurial-devel
