Ryan McElroy <r...@fb.com> writes:

> On 2/20/18 11:44 PM, Sean Farley wrote:
>> Ryan McElroy <r...@fb.com> writes:
>>
>>> # HG changeset patch
>>> # User Ryan McElroy <rmcel...@fb.com>
>>> # Date 1519040197 28800
>>> #      Mon Feb 19 03:36:37 2018 -0800
>>> # Node ID 6b80188783ee2626030113a9b2319f2fd14a8119
>>> # Parent  905b79d62df82d8ca16ecac175e6236fe959f4ed
>>> Back out "remotenames: push anonymous head if --force is given"
>>>
>>> Original commit changeset: 905b79d62df8
>>>
>>> There are already two ways to do this:
>>> * set remotenames.forcecompat = True
>>> * set remotenames.pushanonheads = True
>>>
>>> The backed out revision violated the expectation of someone who does not 
>>> have
>>> forcecompat = true. It also did not have any tests.
>> I actually quite liked this, to be honest. Those settings are fairly
>> unintuitive settings and --force is the de facto way to override a push
>> on the client.
>>
>> Also, it seems you pushed this less than a day (which was a holiday!) of
>> it being on the list. That's seems a bit rushed, no?
>
> Sorry I'm out of touch with US holidays. I pushed in draft phase and I'm happy
> to drop them all.

It's alright. I was thinking of maybe just going ahead and splitting the
extension up before this sprint. We can just punt on this and discuss it
there.

Attachment: signature.asc
Description: PGP signature

_______________________________________________
Mercurial-devel mailing list
Mercurial-devel@mercurial-scm.org
https://www.mercurial-scm.org/mailman/listinfo/mercurial-devel

Reply via email to