quark added inline comments.
INLINE COMMENTS
> durin42 wrote in mdiff.py:34
> Rather than this, let's try to get the xdiffblocks function (and if it's not
> there set it to none), and then we could rework the below code to use
> xdiffblocks instead of blocks if experimental.xdiff is set to true - that'll
> make it easier to do some testing of both codepaths.
The diff functions below do not have an `ui` object. Would you be okay if the
config is global? ex. something like
# mdiff.py
def setdiffalgo(name):
global blocks
if name == 'xdiff':
blocks = ...
else: ...
# dispatch.py
ui = ....
mdiff.setdiffalgo(...)
REPOSITORY
rHG Mercurial
REVISION DETAIL
https://phab.mercurial-scm.org/D2577
To: ryanmce, #hg-reviewers
Cc: quark, durin42, mercurial-devel
_______________________________________________
Mercurial-devel mailing list
Mercurial-devel@mercurial-scm.org
https://www.mercurial-scm.org/mailman/listinfo/mercurial-devel
