pulkit added inline comments.
INLINE COMMENTS
> commands.py:2309
> + else:
> + repo.vfs.write('graftstate', 'False\n')
> nodelines = [repo[rev].hex() + "\n" for rev in revs[pos:]]
To be honest I am not fan of storing data in such format, but that's how we
store data right now. I have finally a series in review where we can use cbor
to serialize data while writing to state files. Look at
https://phab.mercurial-scm.org/D2591. I think if that goes in, we should use
that format to store about `no-commit` flag.
> commands.py:2331
> + nocommitflag = lines[0]
> + if not (opts.get('no_commit') or nocommitflag == 'True'):
> + node = repo.commit(text=message, user=user,
What about if we do `--continue` and `--no-commit`? Also, a lot of existing
flags should error out while using with `--no-commit`. That's also missing.
REPOSITORY
rHG Mercurial
REVISION DETAIL
https://phab.mercurial-scm.org/D2409
To: khanchi97, #hg-reviewers
Cc: pulkit, mercurial-devel
_______________________________________________
Mercurial-devel mailing list
Mercurial-devel@mercurial-scm.org
https://www.mercurial-scm.org/mailman/listinfo/mercurial-devel
