quark added inline comments.

INLINE COMMENTS

> indygreg wrote in bdiff.c:263
> Does our C standard level allow to declare variables after non-declarations 
> in blocks?

Not sure. But the rest is C89. So I'll move this up.

> indygreg wrote in bdiff.c:283
> This exception type is nonsensical. But it is what `blocks()` uses. So not 
> worth worrying about.

It actually makes some sense - if the xdiff library is solid, then 
`hunk_consumer` returning -1 is the only reason things go wrong. And that's 
caused by NoMemory.

REPOSITORY
  rHG Mercurial

REVISION DETAIL
  https://phab.mercurial-scm.org/D2602

To: quark, #hg-reviewers, indygreg
Cc: indygreg, mercurial-devel
_______________________________________________
Mercurial-devel mailing list
Mercurial-devel@mercurial-scm.org
https://www.mercurial-scm.org/mailman/listinfo/mercurial-devel

Reply via email to