durin42 added a comment.
Nice! I've got one suggested edit to the code that should still pass tests.
INLINE COMMENTS
> histedit.py:428-432
> try:
> - rev = node.bin(rulehash)
> + rev = node.bin(ruleid)
> except TypeError:
> - raise error.ParseError("invalid changeset %s" % rulehash)
> + try:
> + _ctx = scmutil.revsingle(state.repo, ruleid)
I think you can replace this outer try with a revsingle call, something like
this:
try:
ruleid = rule.strip().split(' ', 1)[0]
_ctx = scmutil.revsingle(state.repo, ruleid)
rulehash = _ctx.hex()
rev = node.bin(rulehash)
except error.RepoLookupError:
REPOSITORY
rHG Mercurial
REVISION DETAIL
https://phab.mercurial-scm.org/D2394
To: sangeet259, durin42, #hg-reviewers
Cc: tom.prince, krbullock, rishabhmadan96, mercurial-devel
_______________________________________________
Mercurial-devel mailing list
Mercurial-devel@mercurial-scm.org
https://www.mercurial-scm.org/mailman/listinfo/mercurial-devel
