yuja added a comment.

  Queued, thanks.

INLINE COMMENTS

> request.py:31
>      def __init__(self):
>          # Stores (key, value) 2-tuples. This isn't the most efficient. But we
>          # don't rely on parameters that much, so it shouldn't be a perf 
> issue.

Deleted this comment in flight.

> request.py:52
>      def __len__(self):
>          return len(self._items)
>  

The behavior of `len()` changed, but I don't think that matters. The new
behavior should be fine since multidict isn't iterable.

REPOSITORY
  rHG Mercurial

REVISION DETAIL
  https://phab.mercurial-scm.org/D2881

To: indygreg, #hg-reviewers, yuja
Cc: mercurial-devel
_______________________________________________
Mercurial-devel mailing list
Mercurial-devel@mercurial-scm.org
https://www.mercurial-scm.org/mailman/listinfo/mercurial-devel

Reply via email to