indygreg requested changes to this revision. indygreg added a comment. This revision now requires changes to proceed.
Reading through the remainder of the series, I like the customization of stack evaluation. But the use of config options seems weird to me. It isn't clear why we need config options. It feels like these options should be passed in as function arguments. Now, it will be useful to test these variations. Maybe that does require config options. But until there is a user-facing need for these config options, It feels better to put them in `[devel]` or something like that. Is there a future consumer of these config options that justifies them being normal config options? REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D2400 To: lothiraldan, #hg-reviewers, indygreg Cc: indygreg, mercurial-devel _______________________________________________ Mercurial-devel mailing list Mercurial-devel@mercurial-scm.org https://www.mercurial-scm.org/mailman/listinfo/mercurial-devel
