yuja added inline comments.

INLINE COMMENTS

> yuja wrote in commands.py:2474
> > Shall I change that to returning wdirid?
> 
> That isn't easy to answer because `wctx.filenode()` can return
> another pseudo
> hash (e.g. 000000000000000added) if `wctx._manifest` is preloaded.
> 
> > highlight the slowpath part
> 
> It's quite old, so I have no concrete idea. But maybe reusing filelog objects 
> is the key.

I did try that. https://phab.mercurial-scm.org/D2940 .. 
https://phab.mercurial-scm.org/D2942

No idea if they are good or bad.

REPOSITORY
  rHG Mercurial

REVISION DETAIL
  https://phab.mercurial-scm.org/D2938

To: sangeet259, #hg-reviewers
Cc: av6, yuja, pulkit, mercurial-devel
_______________________________________________
Mercurial-devel mailing list
Mercurial-devel@mercurial-scm.org
https://www.mercurial-scm.org/mailman/listinfo/mercurial-devel

Reply via email to