indygreg accepted this revision.
indygreg added a comment.
This revision is now accepted and ready to land.


  This looks reasonable.
  
  Could we also please get an explicit test for `hg pull -r <rev>` in this 
server configuration? Yes, I believe that will be redundant with other tests. 
But it is useful to have explicit coverage for this specific server operation 
mode.

INLINE COMMENTS

> test-infinitepush-ci.t:142
> +
> +XXX: we should have pushed only the parts which are not in bundlestore
> +  $ hg push

I actually think the behavior is acceptable. Having to dynamically overlay 
multiple bundles from the bundle store on the server feels like it will be a 
lot of work. For cases where the server is mainly ingesting ad-hoc commits, it 
is fine to have to re-push changesets.

This could get annoying if people are pushing very large changesets. But until 
we have a better store, I don't think there's much we can do.

REPOSITORY
  rHG Mercurial

REVISION DETAIL
  https://phab.mercurial-scm.org/D2958

To: pulkit, #hg-reviewers, indygreg
Cc: indygreg, mercurial-devel
_______________________________________________
Mercurial-devel mailing list
Mercurial-devel@mercurial-scm.org
https://www.mercurial-scm.org/mailman/listinfo/mercurial-devel

Reply via email to