martinvonz created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers.
REVISION SUMMARY AFAICT (but note that this is the first time I look at hgweb code), the "mercurial" query parameter was removed from rendered pages in https://phab.mercurial-scm.org/rHG36fa5db79dd5c96546c5cb23da6d9aebb6564316 (hgweb: convert gitweb to NWI, 2006-10-05). Search for "manifest=" in that diff to see why I think it was removed. It's about time we stop looking for the parameter in requests. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D3073 AFFECTED FILES mercurial/hgweb/webutil.py CHANGE DETAILS diff --git a/mercurial/hgweb/webutil.py b/mercurial/hgweb/webutil.py --- a/mercurial/hgweb/webutil.py +++ b/mercurial/hgweb/webutil.py @@ -296,23 +296,15 @@ return pathutil.canonpath(repo.root, '', path) def changeidctx(repo, changeid): - try: - ctx = repo[changeid] - except error.RepoError: - man = repo.manifestlog._revlog - ctx = repo[man.linkrev(man.rev(man.lookup(changeid)))] - - return ctx + return repo[changeid] def changectx(repo, req): changeid = "tip" if 'node' in req.qsparams: changeid = req.qsparams['node'] ipos = changeid.find(':') if ipos != -1: changeid = changeid[(ipos + 1):] - elif 'manifest' in req.qsparams: - changeid = req.qsparams['manifest'] return changeidctx(repo, changeid) To: martinvonz, #hg-reviewers Cc: mercurial-devel _______________________________________________ Mercurial-devel mailing list Mercurial-devel@mercurial-scm.org https://www.mercurial-scm.org/mailman/listinfo/mercurial-devel
