yuja requested changes to this revision. yuja added a comment. This revision now requires changes to proceed.
It seems incorrect to me to catch LookupError of `node` returned by a namespace API, not by a user-specified node value. I think the reason why catching `RepoLookupError` here was that we historically used `repo.branchtip(changeid)`. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D3145 To: martinvonz, #hg-reviewers, yuja Cc: yuja, mercurial-devel _______________________________________________ Mercurial-devel mailing list Mercurialfirstname.lastname@example.org https://www.mercurial-scm.org/mailman/listinfo/mercurial-devel