martinvonz added a comment.

  In https://phab.mercurial-scm.org/D3145#50619, @martinvonz wrote:
  
  > In https://phab.mercurial-scm.org/D3145#50598, @yuja wrote:
  >
  > > It seems incorrect to me to catch LookupError of `node` returned by
  > >  a namespace API, not by a user-specified node value.
  >
  >
  > The idea wasn't to catch those from the namespace API, but from 
changelog.rev() just after. The overly broad catching has bothered me before, 
so let me fix that and split this patch up.
  
  
  Actually, thinking more about, I think we should not even catch LookupError, 
so I ended up just deleting these lines. Thanks for making me check.
  
  > 
  > 
  >> I think the reason why catching `RepoLookupError` here was that
  >>  we historically used `repo.branchtip(changeid)`.
  > 
  > Ah, thanks for the information.

REPOSITORY
  rHG Mercurial

REVISION DETAIL
  https://phab.mercurial-scm.org/D3145

To: martinvonz, #hg-reviewers, yuja
Cc: yuja, mercurial-devel
_______________________________________________
Mercurial-devel mailing list
Mercurial-devel@mercurial-scm.org
https://www.mercurial-scm.org/mailman/listinfo/mercurial-devel

Reply via email to