indygreg requested changes to this revision.
indygreg added inline comments.
This revision now requires changes to proceed.

INLINE COMMENTS

> histedit.py:446
>          ha = node.hex(self.node)
> -        try:
> -            self.node = repo[ha].node()
> -        except error.RepoError:
> -            raise error.ParseError(_('unknown changeset %s listed')
> -                              % ha[:12])
> +        self.node = repo.unfiltered().changelog._partialmatch(ha)
> +        if self.node is None:

Err wait. Why is `repo.unfiltered()` being used here? If the previous code 
worked on on the filtered repo, shouldn't this code?

The side effect of this change is that a histedit rule could reference a hidden 
changeset. That feels wrong.

REPOSITORY
  rHG Mercurial

REVISION DETAIL
  https://phab.mercurial-scm.org/D3158

To: martinvonz, durin42, #hg-reviewers, indygreg
Cc: indygreg, mercurial-devel
_______________________________________________
Mercurial-devel mailing list
Mercurial-devel@mercurial-scm.org
https://www.mercurial-scm.org/mailman/listinfo/mercurial-devel

Reply via email to