yuja added inline comments.

INLINE COMMENTS

> wireproto.py:1231
> +def listkeysv2(repo, proto, namespace=None):
> +    keys = repo.listkeys(encoding.tolocal(namespace))
> +    keys = {encoding.fromlocal(k): encoding.fromlocal(v)

Nit: if `namespace` could be `None`, this would crash.

REPOSITORY
  rHG Mercurial

REVISION DETAIL
  https://phab.mercurial-scm.org/D3181

To: indygreg, #hg-reviewers, yuja
Cc: mercurial-devel
_______________________________________________
Mercurial-devel mailing list
Mercurial-devel@mercurial-scm.org
https://www.mercurial-scm.org/mailman/listinfo/mercurial-devel

Reply via email to