yuja added inline comments. INLINE COMMENTS
> wireproto.py:526 > + elif isinstance(args, dict): > + return func(repo, proto, **args) > + else: My two cents. I think it's better to pass `args` dict without expansion. `**args` means we can't use `repo` and `proto` as parameter names. > wireproto.py:1209 > + > +# Wire protocol version 2 commands only past this point. > + Maybe we'll need a separate v2 command module? REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D3179 To: indygreg, #hg-reviewers, yuja Cc: mercurial-devel _______________________________________________ Mercurial-devel mailing list Mercurial-devel@mercurial-scm.org https://www.mercurial-scm.org/mailman/listinfo/mercurial-devel
