indygreg added inline comments.


> yuja wrote in
> My two cents. I think it's better to pass `args` dict without expansion.
> `**args` means we can't use `repo` and `proto` as parameter names.

I agree about not using ``**args``. It is there mostly for compatibility with 
existing command handlers. Once we have a distinct set of handlers, we can 
ditch ``**args``.

> yuja wrote in
> Maybe we'll need a separate v2 command module?

I also think it makes sense to separate things into separate modules. However, 
there are a number of cycles involved. I'll try to do this. Not sure if I'll 
make it before 4.6 freeze though.

  rHG Mercurial


To: indygreg, #hg-reviewers, yuja
Cc: mercurial-devel
Mercurial-devel mailing list

Reply via email to