martinvonz added inline comments.

INLINE COMMENTS

> yuja wrote in scmutil.py:439
> We'll need to verify that the returned node is NOT hidden by e.g.
> calling `changelog.rev(node)`.
> 
> It's unlikely that callers expect this function may return a hidden
> node.

Makes sense. Okay if I do that in a follow-up so the rest of the stack is not 
blocked by this (I will be away until Friday)?

REPOSITORY
  rHG Mercurial

REVISION DETAIL
  https://phab.mercurial-scm.org/D3189

To: martinvonz, #hg-reviewers, yuja
Cc: yuja, mercurial-devel
_______________________________________________
Mercurial-devel mailing list
Mercurial-devel@mercurial-scm.org
https://www.mercurial-scm.org/mailman/listinfo/mercurial-devel

Reply via email to