indygreg accepted this revision.
indygreg added a comment.
This revision is now accepted and ready to land.


  I'm not crazy about the implementation. But for an experimental feature, I 
think it is fine. The bundle2 changes to do this right are definitely scope 
bloat.

INLINE COMMENTS

> exchange.py:491
> +    if repo.ui.configbool('experimental', 'remotenames'):
> +        logexchange.pullremotenames(repo, remote)
> +

In a bundle2 world, the news names would ideally be returned by a bundle2 part 
(this will require 2 extra round trips to the server as implemented). But I 
think this implementation is fine for an experimental feature.

Also, if the local repo doesn't have names from the remote, we'll never see 
them. At some point down the long shallow clone road, we'll need to consider 
what we should be about nodes we know exist remotely but aren't available 
locally. But this problem can be deferred for a while.

REPOSITORY
  rHG Mercurial

REVISION DETAIL
  https://phab.mercurial-scm.org/D2874

To: pulkit, #hg-reviewers, indygreg
Cc: indygreg, mercurial-devel
_______________________________________________
Mercurial-devel mailing list
Mercurial-devel@mercurial-scm.org
https://www.mercurial-scm.org/mailman/listinfo/mercurial-devel

Reply via email to