On Sat, 14 Apr 2018 14:09:42 -0400, Matt Harbison wrote:
> On Sat, 14 Apr 2018 03:09:01 -0400, Yuya Nishihara <y...@tcha.org> wrote:
> > On Fri, 13 Apr 2018 23:30:43 -0400, Matt Harbison wrote:
> >> Assuming the semaphore is persistent, it could be beneficial to load
> >> extensions indicated by it around the normal load time (e.g., largefiles
> >> wraps the clone command and adds extra switches).
> >>
> >> I'm not sure if this addresses Yuya's concern about long lived processes
> >> though.
> >
> > If the extensions to be loaded are bound to a repo, yes, that should be
> > fine. A well-designed extension should check the repo requirements. What
> > doesn't work in command server is to load extensions per-command basis.
> While "bound to a repo" makes it sound like the extension would be
> isolated and could unload if the repo is GC'd, what I don't get is what
> that phrase means for all of the module functions that are wrapped.

I mean extension authors (and command-server clients) have to take care of
that situation anyway, because extensions may be enabled by repo hgrc. The
simplest solution for command-server clients is to spawn processes per
repository, which is what TortoiseHg does.
Mercurial-devel mailing list

Reply via email to