Yuya Nishihara <y...@tcha.org> writes: > On Mon, 28 May 2018 21:27:40 +0900, Yuya Nishihara wrote: >> On Sun, 27 May 2018 13:48:18 +0200, Sean Farley wrote: >> > # HG changeset patch >> > # User Sean Farley <s...@farley.io> >> > # Date 1527357855 -7200 >> > # Sat May 26 20:04:15 2018 +0200 >> > # Node ID 9fa3f81f4685ca73393f57253f2f05a0d758c022 >> > # Parent 000e9442997b1c61ae02a27e657ffb34d170502b >> > # EXP-Topic gca-revset >> > revset: add an 'all' argument to ancestor() to return >> > >> > Currently, I'm not sure if this should be an option or a new revset >> > method. >> >> Maybe this can be an optimized path for 'heads(::x, ::y)'? >> commonancestorsheads() is documented as such. > > To be clear, I thought this should be a new revset function since 'all' could > also mean "all ancestors." And I noticed that it could be a private function > '_ancestorheads(x, y)' rewritten from 'heads(::x, ::y)'.
Yeah, I think I agree that it should be a new revset; thanks. I'm not quite sure what optimization you mean for heads(::x, ::y), though?
signature.asc
Description: PGP signature
_______________________________________________ Mercurial-devel mailing list Mercurial-devel@mercurial-scm.org https://www.mercurial-scm.org/mailman/listinfo/mercurial-devel