khanchi97 added inline comments. INLINE COMMENTS
> pulkit wrote in phases.py:395 > Add documentation about dry-run and the return value. okay > pulkit wrote in phases.py:417 > Why are we not using this affected set here to find the changesets whose > phase is changed? Because I think this affected set is calculated after performing actions, when phases are changed. And calculating affected using new phaseroots. Am I missing something here? > pulkit wrote in phases.py:430 > (Not sure which line I should put this comment on) > > Just like https://phab.mercurial-scm.org/D3671, here also, the function > should return the correct set of changes whose phase have been changed > irrespective of the dryrun value passed. yeah, I got it. > pulkit wrote in phases.py:511 > This should better be: > > `If dryrun is True, no actions will be performed > > returns a set of revs whose phase is changed or should be changed` okay, will do this for 'advanceboundry' too REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D3672 To: khanchi97, #hg-reviewers Cc: pulkit, mercurial-devel _______________________________________________ Mercurial-devel mailing list Mercurial-devel@mercurial-scm.org https://www.mercurial-scm.org/mailman/listinfo/mercurial-devel