smf added a comment.

  Greg and Jun,
  
  Before anyone else requests more changes or anything, this is a first time 
contributor and I was trying to be a bit more flexible as a reviewer. I 
actually queued the patch yesterday but due to the test failures, I haven't 
pushed. I'll personally fix up the tests and add the experimental flag.
  
  John,
  
  Don't worry about updating this patch or rebasing. I've already (locally) 
added "EXPERIMENTAL" and am fixing the other test failures, too. I just haven't 
finished yet because I'm trying to also finish my household chores :-P I'll 
post a diff of what I tweaked when I finish this weekend. Thanks for bearing 
with me on this discussion!

REPOSITORY
  rHG Mercurial

REVISION DETAIL
  https://phab.mercurial-scm.org/D3665

To: johnstiles, #hg-reviewers, spectral, indygreg
Cc: quark, spectral, indygreg, smf, yuja, mercurial-devel
_______________________________________________
Mercurial-devel mailing list
Mercurial-devel@mercurial-scm.org
https://www.mercurial-scm.org/mailman/listinfo/mercurial-devel

Reply via email to