On Thu, 28 Jun 2018 15:48:59 -0700, Martin von Zweigbergk wrote: > On Thu, Jun 28, 2018 at 6:43 AM Yuya Nishihara <y...@tcha.org> wrote: > > > # HG changeset patch > > # User Yuya Nishihara <y...@tcha.org> > > # Date 1529159200 -32400 > > # Sat Jun 16 23:26:40 2018 +0900 > > # Node ID 0005175b53bb3f829578757c1c34eab60c7c42a8 > > # Parent fe4560fa5db2f1ee11cff233c55b7685e891517a > > revset: move lookup of first ancestor() candidate out of the loop > > > > Queuing this series, thanks. > > What's the motivation for this patch? Does it make some case faster or did > you just not like the condition inside the loop?
Good question. I just feel initializing variable out of the loop is better. There's no performance improvement. _______________________________________________ Mercurial-devel mailing list Mercurial-devel@mercurial-scm.org https://www.mercurial-scm.org/mailman/listinfo/mercurial-devel
