yuja added a comment.

  >   I think it would make sense to defer the behavior change until we test 
some more. That said, I do want us to plan to make an intentionally breaking 
change with the out of the box grep experience *without* `tweakdefaults` 
enabled. My reasoning is more or less this: approximately nobody uses `hg grep` 
today[0] because its behavior doesn't match what users expect out of the box. 
I'm willing to call the current behavior a *bug*, and prominently announce that 
with 4.8 we expect to change the default behavior of `hg grep` to match user 
expectations. That's in line with the decision outlined in [1] which is old 
enough that mpm was part of the decision. I strongly suspect hglib will be the 
only meaningful breakage, and we can patch hglib to pass the -r 0:tip flag 
that'll give consistent behavior across all hg versions.
  
  If we can take the current `hg grep` behavior as a bug, we can say the
  same thing for python-hglib. I don't want to make hglib grep diverged from
  hg one since hglib is a thin wrapper.

REPOSITORY
  rHG Mercurial

REVISION DETAIL
  https://phab.mercurial-scm.org/D3919

To: yuja, #hg-reviewers, sangeet259, pulkit
Cc: durin42, mercurial-devel
_______________________________________________
Mercurial-devel mailing list
Mercurial-devel@mercurial-scm.org
https://www.mercurial-scm.org/mailman/listinfo/mercurial-devel

Reply via email to