indygreg created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers.
REVISION SUMMARY rev() is part of the imanifestlog interface and should be used instead of using the private revlog instance, which is an implementation detail. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D4269 AFFECTED FILES mercurial/changegroup.py CHANGE DETAILS diff --git a/mercurial/changegroup.py b/mercurial/changegroup.py --- a/mercurial/changegroup.py +++ b/mercurial/changegroup.py @@ -946,8 +946,6 @@ clrevorder = {} mfs = {} # needed manifests mfl = self._repo.manifestlog - # TODO violates storage abstraction. - mfrevlog = mfl._revlog changedfiles = set() clrevtomanifestrev = {} @@ -973,7 +971,7 @@ # manifest revnum to look up for this cl revnum. (Part of # mapping changelog ellipsis parents to manifest ellipsis # parents) - clrevtomanifestrev.setdefault(cl.rev(x), mfrevlog.rev(n)) + clrevtomanifestrev.setdefault(cl.rev(x), mfl.rev(n)) # We can't trust the changed files list in the changeset if the # client requested a shallow clone. if self._isshallow: To: indygreg, #hg-reviewers Cc: mercurial-devel _______________________________________________ Mercurial-devel mailing list Mercurial-devel@mercurial-scm.org https://www.mercurial-scm.org/mailman/listinfo/mercurial-devel
