pulkit added a comment.

  Queued the cbor patches. I think following can improve the code more:
  
  - Having a `cborutil.decodeone()` function which can make sure we only have 
one dcoded value and using that fn instead of `decodeall()[0]`
  - A `cborutil.encode()` function to use where we don't want to do 
`streamencode()` and use that in place of `b''.join()` pattern
  - Checking for an empty string being passed in `cborutil.decodeall()[0]` or 
`cborutil.decodeone()`
  
  What do you think?

REPOSITORY
  rHG Mercurial

REVISION DETAIL
  https://phab.mercurial-scm.org/D4465

To: indygreg, #hg-reviewers, pulkit
Cc: mercurial-devel
_______________________________________________
Mercurial-devel mailing list
Mercurial-devel@mercurial-scm.org
https://www.mercurial-scm.org/mailman/listinfo/mercurial-devel

Reply via email to