martinvonz added a comment.
In https://phab.mercurial-scm.org/D4508#68864, @yuja wrote: > > + self._containsseen = set() > > + self._containsiter = iter(self) > > Perhaps __iter__() needs to be extracted to a free function to avoid > reference cycle. Good point. I'll send a patch before this one to extract a free function. Why do we care about reference cycles again? Because some runtimes don't have GC? REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D4508 To: martinvonz, #hg-reviewers Cc: yuja, mercurial-devel _______________________________________________ Mercurial-devel mailing list Mercurial-devel@mercurial-scm.org https://www.mercurial-scm.org/mailman/listinfo/mercurial-devel
