indygreg added inline comments. INLINE COMMENTS
> martinvonz wrote in narrowspec.py:114-130 > Obsolete copy of what you inlined into parsepatterns? It is a copy, but not obsolete. `parsepatterns()` normalizes patterns supplied by the user or an untrusted source. `validatepatterns` is used on "internal" data structures to ensure things are well-formed. They do similar things but are different. I could extract the common bit to a separate, two-line function and/or update the docstring to reflect the differences. Do you have any preferences? REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D4522 To: indygreg, durin42, #hg-reviewers, martinvonz Cc: martinvonz, mjpieters, mercurial-devel _______________________________________________ Mercurial-devel mailing list Mercurial-devel@mercurial-scm.org https://www.mercurial-scm.org/mailman/listinfo/mercurial-devel