indygreg added inline comments.
INLINE COMMENTS
> test-extension.t:108
> >
> + > bytesname = name.encode('utf-8')
> > # custom predicate to check registration of functions at loading
`name` will already be bytes on Python 2. But, `.encode()` will still work
because Python 2 has an `encode()` on bytes. So I think this is fine. If this
weren't test code, I would have a different opinion.
REPOSITORY
rHG Mercurial
REVISION DETAIL
https://phab.mercurial-scm.org/D4677
To: pulkit, #hg-reviewers
Cc: indygreg, mjpieters, mercurial-devel
_______________________________________________
Mercurial-devel mailing list
Mercurial-devel@mercurial-scm.org
https://www.mercurial-scm.org/mailman/listinfo/mercurial-devel
